validate uniqueness fixes and recurse into array elements, other improvements
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomreitz
changed the title
validate uniqueness fixes and recurse into array elements, other improvements
johncmerfeld
approved these changes
Jan 28, 2025
|
Resolved merge conflicts and ran the test suite to ensure that didn't break anything; merging. |
tomreitz
deleted the
feature/validate_fixes_and_uniqueness_in_array_elements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
uniquenessvalidation method always succeed (as the uniqueness hash list was emptied before processing each payload)uniquenessvalidation method by moving certain preparatory steps (building the identity parameter structure, resolving the swagger reference definition, etc.) outside the payload processing loop (so it's only done once, not for every payload)uniquenessvalidation of array elements within payloads, as requested/discussed in this item